Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch deberta to use the "int" dtype #1315

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

mattdangerw
Copy link
Member

This will be int32 on jax and torch, but int64 on tf, which is what we need for proper accelerator support

This will be int32 on jax and torch, but int64 on tf, which is what we
need for proper accelerator support
@mattdangerw
Copy link
Member Author

Hmm these test failures look unrelated to this change, but instead some recent keras-nightly changes. Will take a look.

Copy link
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdangerw
Copy link
Member Author

/gcbrun

@mattdangerw mattdangerw merged commit 9286561 into keras-team:master Nov 14, 2023
mattdangerw added a commit to mattdangerw/keras-hub that referenced this pull request Dec 7, 2023
This will be int32 on jax and torch, but int64 on tf, which is what we
need for proper accelerator support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants