Restore mask_position argument name #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
ianstenbit
reviewed
Jul 28, 2023
This was actually breaking because of a silly bug in keras-core: keras-team/keras-core#632 We can bring back the original name, though we will need to wait till the fix is in a release to restore `compute_output_shape`.
mattdangerw
force-pushed
the
mask-position-name
branch
from
06c6e43 to
cff5ce6
Compare
|
/gcbrun |
ianstenbit
approved these changes
Jul 30, 2023
jbischof
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually breaking because of a silly bug in keras-core: keras-team/keras-core#632
We can bring back the original name, though we will need to wait till the fix is in a release to restore
compute_output_shape.