Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPTNeoXCausalLMPreprocessor #1106

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Conversation

shivance
Copy link
Collaborator

In favor of #1052

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@@ -14,7 +14,7 @@

"""GPTNeoX preprocessor layer."""
from keras_nlp.api_export import keras_nlp_export
from keras_nlp.layers.start_end_packer import StartEndPacker
from keras_nlp.layers import StartEndPacker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should write this from keras_nlp.layers.preprocessing.start_end_packer import StartEndPacker. I can make this change as I merge.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mattdangerw made the change!

@mattdangerw
Copy link
Member

/gcbrun

@mattdangerw mattdangerw merged commit 2b62a70 into keras-team:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants