Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BART finetuned on CNN+DM for summarisation #1060

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Add BART finetuned on CNN+DM for summarisation #1060

merged 4 commits into from
Jun 8, 2023

Conversation

abheesht17
Copy link
Collaborator

No description provided.

@abheesht17 abheesht17 requested a review from mattdangerw June 4, 2023 01:48
@abheesht17 abheesht17 changed the title Add BART CNN+DM for summarisation Add BART finetuned on CNN+DM for summarisation Jun 6, 2023
@mattdangerw
Copy link
Member

/gcbrun

@abheesht17 abheesht17 requested a review from mattdangerw June 7, 2023 12:54
@mattdangerw
Copy link
Member

/gcbrun

mattdangerw
mattdangerw approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Does it need updates (e.g. hash) for the new weights I just uploaded to the bucket?

@abheesht17
Copy link
Collaborator Author

abheesht17 commented Jun 8, 2023 •
edited
Loading

Code looks good to me. Does it need updates (e.g. hash) for the new weights I just uploaded to the bucket?

Already done! The failed accelerator test is because of DistilBERT, apparently.

@mattdangerw
Copy link
Member

The failed accelerator test is because of DistilBERT, apparently.

Ah probably that's -> #960

Still need to look into that.

Thanks!

@mattdangerw mattdangerw merged commit 3efdb8f into keras-team:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abheesht17 @mattdangerw