Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContrastiveSampler lacks a seed param, while the docstring states it has one #1481

Closed
martin-gorner opened this issue Feb 29, 2024 · 1 comment · Fixed by #1488
Closed

ContrastiveSampler lacks a seed param, while the docstring states it has one #1481

martin-gorner opened this issue Feb 29, 2024 · 1 comment · Fixed by #1488
Labels
type:Bug Something isn't working

Comments

@martin-gorner
Copy link
Contributor

Contrastive samples docs here:
https://keras.io/api/keras_nlp/samplers/contrastive_sampler/

The function signature does not have a "seed" arg:
keras_nlp.samplers.ContrastiveSampler(k=5, alpha=0.6, **kwargs)

But the docstring states:
seed: int. The random seed. Defaults to None.

Probably just a docstring issue. Since this samples is a variant of BeamSampler, it probably does not need a seed.

@martin-gorner martin-gorner added the type:Bug Something isn't working label Feb 29, 2024
@mattdangerw
Copy link
Member

Yep, just a docs issue. Will fix up.

mattdangerw added a commit to mattdangerw/keras-hub that referenced this issue Mar 5, 2024
mattdangerw added a commit that referenced this issue Mar 5, 2024
abuelnasr0 pushed a commit to abuelnasr0/keras-nlp that referenced this issue Apr 2, 2024
Tusespifump1o added a commit to Tusespifump1o/keras-nlp that referenced this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants