Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use correct needs value to kick off docs auto update #635

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Jan 17, 2023

This PR

  • fixes a small issue with the KLT docs auto update pipeline steps. they should get triggered correctly now
  • fixes a broken markdown link

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies changed the title ci: Use correct needs value to kick off docs auto update ci: use correct needs value to kick off docs auto update Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #635 (f46edf3) into main (a84d4e4) will increase coverage by 0.23%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   54.09%   54.32%   +0.23%     
==========================================
  Files          77       77              
  Lines        6446     6446              
==========================================
+ Hits         3487     3502      +15     
+ Misses       2809     2795      -14     
+ Partials      150      149       -1     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
operator/controllers/common/evaluationhandler.go 79.71% <0.00%> (+2.17%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 78.24% <0.00%> (+4.16%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+18.18%) ⬆️
Flag Coverage Δ
component-tests 53.33% <ø> (+2.07%) ⬆️
keptn-cert-manager 67.72% <ø> (ø)
keptn-lifecycle-operator 51.60% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies marked this pull request as ready for review January 17, 2023 12:19
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mowies mowies merged commit 1acaf33 into keptn:main Jan 17, 2023
@mowies mowies deleted the fix-docs-auto-update branch January 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants