Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: use PodSchedulingReadiness API to replace scheduler #632

Closed
wants to merge 15 commits into from
Closed

PoC: use PodSchedulingReadiness API to replace scheduler #632

wants to merge 15 commits into from

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

Fixes: #518

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #632 (231e6e9) into main (1acaf33) will increase coverage by 0.73%.
The diff coverage is 19.64%.

❗ Current head 231e6e9 differs from pull request most recent head e4e5b75. Consider uploading reports for the commit e4e5b75 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   54.23%   54.97%   +0.73%     
==========================================
  Files          77       74       -3     
  Lines        6446     6283     -163     
==========================================
- Hits         3496     3454      -42     
+ Misses       2799     2676     -123     
- Partials      151      153       +2     
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha2/common/common.go 100.00% <ø> (ø)
...lers/lifecycle/keptnworkloadinstance/controller.go 71.36% <0.00%> (-5.49%) ⬇️
operator/webhooks/pod_mutating_webhook.go 35.13% <0.00%> (-0.71%) ⬇️
operator/controllers/common/helperfunctions.go 45.45% <23.40%> (-54.55%) ⬇️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+9.09%) ⬆️
Flag Coverage Δ
component-tests 52.18% <21.56%> (-0.05%) ⬇️
keptn-cert-manager 67.72% <ø> (ø)
scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

odubajDT and others added 13 commits January 16, 2023 14:58
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thschue thschue changed the title PoC: use PodSchedullingReadiness API to replace scheduler PoC: use PodSchedulingReadiness API to replace scheduler Feb 8, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@stale stale bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research: K8s v1.26 PodSchedulingReadiness API to replace our scheduler
1 participant