[fix] improvements for layer type change logic #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
ilyabo
approved these changes
Feb 13, 2025
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
igorDykhta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when switching between Geojson > Point > Heatmap layers the columns end up in an invalid state when using geoarrow point fileds which are also recognized as geojson data.
add an optional
verifyFieldfunction to verify whether a column is valid for a column mode.a layer can end up with unsupported
columnModeafter layer type is switched, so add extra check and try to use one of the default layer configurations in case of unsupportedcolumnMode.findDefaultLayerPropsalso returnsaltPropswith layer configurations that shouldn't be created by default, but are still valid choices.fix for Geojson layer not reacting to column when in
COLUMN_MODE_TABLEmode.