-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] GeoArrow incremental rendering (1) #2459
Merged
ibgreen
merged 7 commits into
keplergl:master
from
GeoDaCenter:xli/batch-render-geoarrow
Dec 9, 2023
Merged
[Feat] GeoArrow incremental rendering (1) #2459
ibgreen
merged 7 commits into
keplergl:master
from
GeoDaCenter:xli/batch-render-geoarrow
Dec 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
This was referenced Nov 30, 2023
ibgreen
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Is this still rendering using multiple GeoJSONLayers? I don't see that in the code...
Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
I think it’s ready. Can’t wait to test it on website. |
Great stuff @lixun910! 👍 |
chrisgervang
pushed a commit
to chrisgervang/kepler.gl
that referenced
this pull request
Dec 19, 2023
Signed-off-by: Xun Li <[email protected]> Signed-off-by: Chris Gervang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to implement progressive rendering of large GeoArrow file by batches. The idea is borrowed from vector tile rendering that each batch (like each tile) is parsed and rendered as a deck.gl geojsonlayer.
(The main thread is not fully blocked even though we don't implement the web worker version)
Note:
Some issues:
Any suggestions or comments will be appreciated. Thanks!