-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] move dev env to Node.js 18 #2399
Conversation
Signed-off-by: Ib Green <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just out of curiosity - do we know of any substantial issues that'd stop us from upgrading to v20/21?
The gap from 18->20 should be much smaller than 14->18 but we don't have much test mileage on v20 yet in the open source. To avoid this dragging out I recommend landing this for now and then make a second pass towards 20 once we have worked through the big OSS upgrade cycle (all the frameworks are going through major releases). |
Of course, not suggesting we do additional work here, was just curious if we already spotted some potential issues with that upgrade. As you noted, there's nothing that stood out to me based on the release notes I went through though |
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Node 14 and Node 16 are no longer official supported Node.js versions.
Node 18 is now the oldest LTS release.
Also loaders.gl has now finally updated to Node 18 which should remove one of the obstacles to upgrading Node in kepler, and conversely, kepler being on Node 18 should facilitate loaders.gl 4.0 integration.
It looks like we need
NODE_OPTIONS=--openssl-legacy-provider
in a lot of extra places in addition to what was revealed by CI. Either add them or upgrade webpack to 5.x. >> Added NODE_OPTIONS in several places, ignoring a ton of rarely used places for now as almost all scripts need extra NODE_OPTIONS set.test website build