2.0 #1732
Open
2.0 #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. God. Yes. |
|
haha |
|
hey folks, this is looking great. Can I start using it? I mean the vanillajs portion? |
|
@mmahalwy Right now I'm working on getting test coverage in place so that I can begin rewriting certain portions. It definitely usable, but I havent removed the $ dep yet |
|
Any idea when 2.0 is going to be finished? Would be nice to get the smooth scrolling feature. |
The only acceptable way to handle the ready function in jQuery is now: jQuery(function($) { /** whatever **/});
jQuery's 'ready' event deprecated
|
I think this should release to npm as an |
replacing new JQuery wrappings of `window` and `document` with a single instance referenced by global variables
Replacing constant window/document wrapping with single wrapped reference
|
@kenwheeler Sorry for being pushy, but is there any update on this PR? Is it still the plan to release slick without a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.