Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade deps #42

Merged
merged 1 commit into from
Oct 27, 2017
Merged

fix: upgrade deps #42

merged 1 commit into from
Oct 27, 2017

Conversation

kentcdodds
Copy link
Owner

What: Upgrades all deps

Why: Good to keep things updated. Also I think this may fix issues with jest and babel-plugin-istanbul because of this: floatdrop/require-from-string#10

How: npx npm-check -u

I also simplified some tests

@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         100    101    +1     
  Branches       21     21           
=====================================
+ Hits          100    101    +1
Impacted Files Coverage Δ
src/macro.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df57424...93e3a5a. Read the comment docs.

I think this may fix issues with jest and `babel-plugin-istanbul`
@kentcdodds kentcdodds merged commit ec3df93 into master Oct 27, 2017
@kentcdodds kentcdodds deleted the pr/upgrade-deps branch October 27, 2017 22:52
@kentcdodds
Copy link
Owner Author

Nope... still having issues with babel-plugin-istanbul and babel-plugin-preval :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant