Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined #24

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Conversation

andreineculau
Copy link
Contributor

What: handle undefined exports
Why: so we don't crash
How: magic

@codecov
Copy link

codecov bot commented Jul 19, 2017

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          94     97    +3     
  Branches       18     19    +1     
=====================================
+ Hits           94     97    +3
Impacted Files Coverage Δ
src/object-to-ast.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5ba72...e123d02. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit! Thanks!

@kentcdodds kentcdodds merged commit 34779bd into kentcdodds:master Jul 19, 2017
@kentcdodds
Copy link
Owner

Would you like to add yourself to the contributors table?

@andreineculau
Copy link
Contributor Author

I'm good. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants