Skip to content

Commit

Permalink
refactor: remove unused digest fn args
Browse files Browse the repository at this point in the history
  • Loading branch information
kentbull committed Aug 25, 2024
1 parent c03b9a0 commit c105190
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 14 deletions.
9 changes: 1 addition & 8 deletions src/lib/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,8 @@ export function deriveSAIDBytes(
}

const ser = serialize({ ...data }, kind)
const args: [number | undefined, number | undefined] = [undefined, undefined]
if (digestage.size != undefined) {
args.push(digestage.size)
}
if (digestage.length != undefined) {
args.push(digestage.length)
}

const raw = digestage.fn(ser, ...args)
const raw = digestage.fn(ser)
validateRawSize(raw, code)

return [raw, data]
Expand Down
12 changes: 6 additions & 6 deletions src/lib/digests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class SAIDAlgoCodex extends Codex {
}
export const SAIDDex = new SAIDAlgoCodex() // Create an instance of SAIDAlgoCodex

type DigestFn = (ser: Uint8Array, digestSize: number | undefined, length: number | undefined) => Buffer
type DigestFn = (ser: Uint8Array) => Buffer

/**
* A class for storing a digest function and its size (not default) and length.
Expand Down Expand Up @@ -63,18 +63,18 @@ export const DigestAlgoMap = new Map<string, Digestage>([
[SAIDDex.SHA3_256, new Digestage(deriveSHA3_256, 32, 0)],
])

function deriveBlake3_256(ser: Uint8Array, _digestSize: number | undefined, _length: number | undefined): Buffer {
return Buffer.from(blake3.create({ dkLen: 32 }).update(ser).digest())
function deriveBlake3_256(ser: Uint8Array): Buffer {
return Buffer.from(blake3(ser, { dkLen: 32 }))
}

function deriveBlake2b_256(ser: Uint8Array, _digestSize: number | undefined, _length: number | undefined): Buffer {
function deriveBlake2b_256(ser: Uint8Array): Buffer {
return Buffer.from(blake2b(ser, { dkLen: 32 }))
}

function deriveSHA2_256(ser: Uint8Array, _digestSize: number | undefined, _length: number | undefined): Buffer {
function deriveSHA2_256(ser: Uint8Array): Buffer {
return Buffer.from(sha256(ser))
}

function deriveSHA3_256(ser: Uint8Array, _digestSize: number | undefined, _length: number | undefined): Buffer {
function deriveSHA3_256(ser: Uint8Array): Buffer {
return Buffer.from(sha3_256(ser))
}

0 comments on commit c105190

Please sign in to comment.