Skip to content
This repository has been archived by the owner on Feb 6, 2025. It is now read-only.

Add a few missing type hints. #978

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Add a few missing type hints. #978

merged 2 commits into from
Dec 9, 2020

Conversation

obi1kenobi
Copy link
Contributor

I found a missing -> None so I opened this PR to fix it.

Below the missing -> None, I ran into a bit of an issue. I wasn't sure what the type hint for SQL compilation should be, so I opened #977. Maybe @bojanserafimov or @chewselene can propose a better type hint than Any for that, and then we can make it explicitly written into the module.

@obi1kenobi obi1kenobi added the maintainer quality-of-life Features that ease development, but are not necessarily visible to package users. label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #978 (349a086) into main (bf66f8b) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   94.27%   93.87%   -0.41%     
==========================================
  Files         113      113              
  Lines        8893     8975      +82     
==========================================
+ Hits         8384     8425      +41     
- Misses        509      550      +41     
Impacted Files Coverage Δ
graphql_compiler/query_formatting/common.py 97.87% <100.00%> (ø)
...ql_compiler/schema_transformation/rename_schema.py 86.73% <0.00%> (-12.81%) ⬇️
graphql_compiler/schema_transformation/utils.py 93.04% <0.00%> (-2.17%) ⬇️
graphql_compiler/compiler/compiler_frontend.py 98.57% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf66f8b...349a086. Read the comment docs.

@pmantica1
Copy link
Contributor

I am going to approve and merge this PR. The output type can be made more precise in the PR that addresses #978.

pmantica1
pmantica1 previously approved these changes Dec 8, 2020
@pmantica1
Copy link
Contributor

Linting is failing.

@pmantica1 pmantica1 merged commit 1614e77 into main Dec 9, 2020
@pmantica1 pmantica1 deleted the add_missing_type_hint branch December 9, 2020 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainer quality-of-life Features that ease development, but are not necessarily visible to package users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants