Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize query planning and execution #1011

Merged
merged 3 commits into from
Apr 22, 2021
Merged

reorganize query planning and execution #1011

merged 3 commits into from
Apr 22, 2021

Conversation

chewselene
Copy link
Collaborator

Moving query planning and execution to its own directory (name is lengthy - open to shorter suggestions!). Reorganize make_query_plan so that public methods live in the Public API section.

Part of the refactor in #1008

@obi1kenobi
Copy link
Contributor

How about just query_planning as the module name? I think one wouldn't be particularly surprised by the ability to execute the planned queries within that module.

@obi1kenobi
Copy link
Contributor

You can run typing_copilot init --overwrite to bypass the mypy and typing copilot CI blocks, otherwise they'll want you to type-hint all the code you moved, which is getting significantly refactored anyway in an immediate-future PR.

obi1kenobi
obi1kenobi previously approved these changes Apr 22, 2021
@chewselene chewselene merged commit 56d8865 into main Apr 22, 2021
@chewselene chewselene deleted the query_plan_reorg branch April 22, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants