Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with conversion from IDR #14

Closed
rene-the-hacker opened this issue Feb 15, 2016 · 3 comments
Closed

Problem with conversion from IDR #14

rene-the-hacker opened this issue Feb 15, 2016 · 3 comments
Assignees
@kennedyoliveira
Labels
bug

Comments

@rene-the-hacker
Copy link

screen shot 2016-02-15 at 15 06 09

Seems like calculation error since IDR exchange rate is pretty high :)
@kennedyoliveira
Copy link
Owner

Hello @drreen!

I checked and its not a calculation error, at least not from me haha
i use yahoo to fetch the rates and they are returning the rate "0.0001" :s
i'll implement and alternative way of calculating this rate, and will notify you as soon as i finish

Thx for reporting!

kennedyoliveira added a commit that referenced this issue Feb 18, 2016
@kennedyoliveira
Fixing #14
83cc262 
The yahoo query language returns the minimum of 0.0001 rate, with is not suficient for some high rates like IDR, so i made a workaround, when the serice returns 0.0001 then i search for the inverted conversion, and calc the rates.
Ex: 1 IDR USD  -> returns 0.0001 so i search for 1 USD IDR and calc using 1 / rate and use it to convert
@kennedyoliveira
Copy link
Owner

Hey @drreen, i fixed it!
Check the new version v2.4.3! Run rateupdate

fix

@kennedyoliveira kennedyoliveira self-assigned this Feb 18, 2016
@kennedyoliveira
Copy link
Owner

@drreen, you didn't say anything, i'm closing the issue, since it's appear to be working just fine, if you have any further problem, feel free to open a new one or reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennedyoliveira kennedyoliveira

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rene-the-hacker @kennedyoliveira