Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitting filters fix for lowercase methods requests - Take 2 #647

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

sdogruyol
Copy link
Member

Follow up on #564 according to @straight-shoota comment this treats post method as a new route.

I'm not sure why the filters_spec fail when ran with all the specs. It passes on its' own.

@sdogruyol
Copy link
Member Author

sdogruyol commented Sep 14, 2022

Found the culprit for the spec failure, Kemal.config.clear clears the FILTER_HANDLERS and does not register afterwards https://github.com/kemalcr/kemal/blob/master/spec/spec_helper.cr#L87

@sdogruyol sdogruyol merged commit c8f857d into master Sep 15, 2022
toddsundsted added a commit to toddsundsted/ktistec that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants