New option to set application name #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing "Kemal" in startup and shutdown messages confuses user when the static binary is deployed at customer setup. This PR adds a option to set App name so that it will be shown when the application starts and shutdown. Example: ``` require "kemal" get "/" do "Hello App!" end Kemal.config.app_name = "helloapp" Kemal.run ``` Shows message as follows ``` [development] helloapp is ready to lead at http://0.0.0.0:3000 ``` Signed-off-by: Aravinda Vishwanathapura <[email protected]>
mamantoha
approved these changes
Apr 5, 2021
straight-shoota
approved these changes
Apr 5, 2021
aravindavk
added a commit
to kadalu/moana
that referenced
this pull request
Apr 6, 2021
* Also using `6e72ebb447caa29e9868af546d1d0b2343a68553` of Kemal library to use the `app_name` feature( kemalcr/kemal#606) * Added `shards version` to get version from `shard.yml` file Signed-off-by: Aravinda Vishwanathapura <[email protected]>
aravindavk
added a commit
to kadalu/moana
that referenced
this pull request
Apr 6, 2021
* Also using `6e72ebb447caa29e9868af546d1d0b2343a68553` of Kemal library to use the `app_name` feature( kemalcr/kemal#606) * Added `shards version` to get version from `shard.yml` file Signed-off-by: Aravinda Vishwanathapura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing "Kemal" in startup and shutdown messages confuses user
when the static binary is deployed at customer setup.
This PR adds a option to set App name so that it will be shown
when the application starts and shutdown.
Example:
Shows message as follows
Signed-off-by: Aravinda Vishwanathapura [email protected]