Use Radix v0.4.0 #596
Merged
Use Radix v0.4.0 #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest release version of Radix in order to address some of the routing bugs presented in previous versions of the dependency See: - luislavena/radix#23 - luislavena/radix#27
mamantoha
approved these changes
Feb 3, 2021
straight-shoota
approved these changes
Feb 3, 2021
sdogruyol
approved these changes
Feb 13, 2021
There was a problem hiding this comment.
Thank you @luislavena ❤️ Is there any performance boost in the latest Radix 🤔
No specific performance change, only bug fixes. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Use latest release version of Radix in order to address some of the
routing bugs presented in previous versions of the dependency
See:
Benefits
Corrects the bugs experienced in the above issues 😁
Possible Drawbacks
None that I can see from running the specs and a few manual tests.
Radix has been tested against Crystal 0.35.0 through 0.36.1 without issues (Kemal is failing on latest versions, but that is a separate issue).
Cheers,
❤️ ❤️ ❤️