Allow for disabling the shutdown message #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, it is still on, but config.shutdown_message can toggle it off
sdogruyol
reviewed
Jan 15, 2017
| @@ -42,6 +43,14 @@ module Kemal | |||
| @logger = logger | |||
| end | |||
|
|
|||
| def shutdown_message(status : Bool) | |||
| @shutdown_message = status | ||
| end | ||
|
|
||
| def shutdown_message? |
There was a problem hiding this comment.
This can be implemented as a getter method like
getter :shutdown_message
alex-lairan
reviewed
Jan 16, 2017
| @@ -17,6 +17,9 @@ module Kemal | |||
| property host_binding, ssl, port, env, public_folder, logging, running, | |||
| always_rescue, serve_static : (Bool | Hash(String, Bool)), server, extra_options | |||
|
|
|||
| getter :shutdown_message | |||
| setter :shutdown_message | |||
There was a problem hiding this comment.
Thanks. Still learning crystal, should have looked up that line above 💃
|
This also fixes the other half of #290 |
|
Is there anything else you'd like me to update or is there a chance for this to be merged? |
|
Hey thanks for the PR. I wasn't sure about this till now 👍 Could you please also send a PR documentation for this at https://github.com/kemalcr/kemalcr.com |
|
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, it is still on, but config.shutdown_message can toggle it off: