controller flags for ignoreDrainFailures and drainTimeout

[shreyas-badiger]

No description provided.

[codecov]

Codecov Report

Merging #307 (9e4fa18) into controller-v2 (4d1afe8) will decrease coverage by 0.67%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           controller-v2     #307      +/-   ##
=================================================
- Coverage          39.08%   38.40%   -0.68%     
=================================================
  Files                  7        7              
  Lines                678      690      +12     
=================================================
  Hits                 265      265              
- Misses               388      400      +12     
  Partials              25       25              

Flag	Coverage Δ
unittests	38.40% <0.00%> (-0.68%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
controllers/rollingupgrade_controller.go	0.00% <ø> (ø)
controllers/upgrade.go	44.41% <0.00%> (-1.59%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1afe8...9e4fa18. Read the comment docs.

[eytan-avisror]

LG, can you just add a few test cases that test the default value vs. flag vs. cr?
e.g. if CR value is nil, it should be the default flag option., if CR is value is nil & flag is provided, it should be flag value, if CR is not nil, it should be the CR value

[shreyas-badiger]

LG, can you just add a few test cases that test the default value vs. flag vs. cr? e.g. if CR value is nil, it should be the default flag option., if CR is value is nil & flag is provided, it should be flag value, if CR is not nil, it should be the CR value

Yes. It will be hard to check which one got enforced. Let me try anyway.

[shaoxt]

LGTM