Fixed Installation Reference Walkthrough doc to have correct paths #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 6 6
Lines 825 825
=======================================
Hits 603 603
Misses 162 162
Partials 60 60Continue to review full report at Codecov.
|
eytan-avisror
approved these changes
Feb 12, 2020
|
@eytan-avisror Thanks. I've signed the CLA. |
thomaswhitcomb
added a commit
to thomaswhitcomb/instance-manager
that referenced
this pull request
Mar 2, 2020
added detail on fargate scheduling and roles simple loopback working simple request/response loopback Fixed Installation Reference Walkthrough doc to have correct paths (keikoproj#74)
Merged
eytan-avisror
added a commit
that referenced
this pull request
Jun 15, 2020
* confirming requirements/approach * fixed up some indentation * replaced tabs with spaces * Simple req/resp loopback for fargate added detail on fargate scheduling and roles simple loopback working simple request/response loopback Fixed Installation Reference Walkthrough doc to have correct paths (#74) * creates and deletes profiles * state machine for creating/deleting fargate profiles * squash this * recode complete * support the cascade delete of role and profile * create, apply and delete working * includes logic to prevent creation/deleting of profiles while deleting other profiles * fixed value v reference bug * fix early return from HasChanged. Did a DeMorgan * Took out some unnecessary log.info calls and added some comments * Tableized the StateDiscovery tests * Updated vendor/ * immutable profiles with reconciliation for all AWS calls * References to values * merged AwsFargateWorker and AwsWorker * clean up vendor * barebones create and delete profile bdd tests * whoops, forgot the fargate template * refactored to new provisioner design * removed 04_instance-manager.yaml * moved retry exception logic to provisioner, refactored the aws provider to make more reuse, restructed eksfargate block in controllers/instancegroup_controller.go * added test for instancegroup_types, removed an orphaned aws function, enforced a 'managed' strategy for eks-fargate * merged master * added instancegroups_types test * tested createfargateprofile interface * removed Fargate Profile Name * hashed the profile name and default execution role name Co-authored-by: Eytan Avisror <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning of the doc, we have the following instruction
The next command has the correct path for the CloudFormation template, but all of the subsequent commands have the wrong paths. This PR is to fix all the wrong paths.