-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aws-sdk-go for IRSA #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 6 6
Lines 825 825
=======================================
Hits 603 603
Misses 162 162
Partials 60 60 Continue to review full report at Codecov.
|
Thanks for the PR! This change should be well tested before merging. in upgrade manager we had to roll this back: Did you get a chance to test full reconciles with this new SDK version? |
Thanks for the review! Oh, I haven't known the issue (aws/aws-sdk-go#2972). With Like the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding this.
Fixes #68
Update go.mod for upgrading AWS SDK[1] for IRSA
IRSA can then provide AWS permissions to the instance-manager controller pod that uses that service account. :-)
[1] https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html
I think the controller works well with upgrading aws-sdk-go