Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh_due
returns True before the record expires.Because there is a "20% of TTL" time span between "refresh" and "expire", this can cause an outgoing packets surge due to cache refresh. The fix is: only refresh once for any refresh-due record.
To debug this issue and to help similar debugging in the future, I also added a metrics (counters) for outgoing traffic. A user can easily pull the metrics by calling
get_metrics
of the daemon, and userecv()
ortry_recv()
.Fix a problem in
retransmission
: currently the retransmissions is aBTreeMap
and there is a non-zero chance that two retransmissions are scheduled with the samenext_time
, hence the 2nd one will overwrite the first one in the BTreeMap due to the same key. The fix is to change the data structure to aVec
.Updated the integration test to cover the metrics.