Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback dns_parser.rs from mdns-parser subcrate to mdns-sd crate #297

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

keepsimple1
Copy link
Owner

This is rolling back the changes of PR #284 . The main reasons are:

  • Increased complexity of this repo. I felt it's more difficult to maintain mdns-sd now.
  • According to crates.io, it seems not many users of the extracted sub crate mdns-parser.

Overall, I felt it was not a good trade-off at this point. If we were to extract the parser in the future, it's probably better / cleaner to move it to its own repo.

@keepsimple1 keepsimple1 merged commit a2814fd into main Feb 2, 2025
3 checks passed
@keepsimple1 keepsimple1 deleted the rollback branch February 2, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant