-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support name probing and conflict resolution #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve issue #264 . The main changes are:
probing
as in RFC 6762 section 8.1 .Simultaneous Probe Tiebreaking
as in RFC 6762 section 8.2conflict resolution
as in RFC 6762 section 9 .Public API changes:
By default, name probing is enabled for publishing a service. Hence there will be around 1 second delay of successful service publishing.
A new API
ServiceInfo::set_requires_probe()
to allow users to disable probing (at the service level) if they are sure there are no conflicts. This could be used if the service publisher does not want any delay due to probing.A new
DaemonEvent::NameChange(DnsNameChange)
is added to send notification about conflict resolution.DnsNameChange
is like this:RR_TYPE_A
, etc. It makes it easier to check the value ofDnsNameChange.rr_type
.Minimum Rust version changed from
1.63.0
to1.65.0
to allow usage oflet ... else
statement.The example code
register.rs
now requires to specify ahostname
to allow easier testing conflict resolution.