Bugfix: AddressesRemoved event does not contain removed addrs #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
force-pushed
the
fix-hostname-addr-removed
branch
from
d9dea29 to
7d2d691
Compare
|
Rebased to the latest main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
HostnameResolutionEvent::AddressesRemovedevent was sent, the addresses included are the ones still in use. They should be the addressses got removed.A test case is added to verify the addresses.
@oysteintveit-nordicsemi if you have time, please check if I missed anything.
(The cache flush test seems flaky, will fix as well)