feat: extract match addr to type as a function #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
reviewed
May 2, 2024
src/dns_parser.rs
Outdated
| @@ -52,6 +52,14 @@ pub const FLAGS_AA: u16 = 0x0400; // mask for Authoritative answer bit | |||
|
|
|||
| pub type DnsRecordBox = Box<dyn DnsRecordExt + Send>; | |||
|
|
|||
| #[inline] | |||
| pub const fn ip_address_to_type(address: IpAddr) -> u16 { | |||
There was a problem hiding this comment.
nitpick: do you mind pass address as &IpAddr ?
src/service_daemon.rs
Outdated
| IpAddr::V4(_) => zc.send_query(hostname, TYPE_A), | ||
| IpAddr::V6(_) => zc.send_query(hostname, TYPE_AAAA), | ||
| } | ||
| zc.send_query(hostname, ip_address_to_type(*ip_addr)); |
There was a problem hiding this comment.
If we pass &IpAddr for the function, then no need to have * here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen the repeated usage of
in multiple places, although this is a very simple operation, it could be extracted into a function (which is what this PR does).
I'm not really sure if the function name
ip_address_to_typeand its location are appropriate.