refresh SRV records and send out ServiceRemoved for expired SRV #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
changed the title
…ecords - Added logic to handle TTL = 0 in responses. - Only apply cache-flush bit if a new record (i.e. rdata changed).
keepsimple1
changed the title
|
Rebased to the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to fix issue raised in #176. There are two parts:
ServiceRemovedwhen SRV record expires as the responder is no longer active.Added a new setter
_set_host_ttl()forDnsRecordto support testing.Also addressed issue #203 : only apply cache-flush bit if the record is new, i.e. rdata changed. Otherwise, it is only a refresh of TTL. This makes sense to me as it can avoid unnecessary new ServiceResolved events.
Also removed
-Wclippy::allfrom CI as it refers the default warnings, hence is redundant with-D warnings. (https://doc.rust-lang.org/clippy/)