Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump socket2 version #174

Merged
merged 10 commits into from
Mar 20, 2024
Merged

bump socket2 version #174

merged 10 commits into from
Mar 20, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

As discussed in previous PR, we only bump the version of socket2 for now

@keepsimple1
Copy link
Owner

Looks like the new socket2 version requires rustc 1.63+. It's okay for us to bump up rustc version to 1.63.

@irvingoujAtDevolution
Copy link
Contributor Author

Looks like the new socket2 version requires rustc 1.63+. It's okay for us to bump up rustc version to 1.63.

updated

@keepsimple1
Copy link
Owner

To fix the build errors, you need to update the CI build.yml .

@keepsimple1
Copy link
Owner

@irvingoujAtDevolution thanks for your work. Will you have the bandwidth to finish this PR in a couple of days? The current build error is due to clippy warnings. (If you are too busy to work on this, I can apply the change in the next release time).

@irvingoujAtDevolution
Copy link
Contributor Author

@irvingoujAtDevolution thanks for your work. Will you have the bandwidth to finish this PR in a couple of days? The current build error is due to clippy warnings. (If you are too busy to work on this, I can apply the change in the next release time).

I will update it today, sorry for the long delay.

@irvingoujAtDevolution
Copy link
Contributor Author

@keepsimple1 Updated rust version, fixed clippy warnings

keepsimple1
keepsimple1 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! I learned something new as well from these clippy fixes. LGTM!

@keepsimple1 keepsimple1 merged commit bccee8e into keepsimple1:main Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keepsimple1 keepsimple1 keepsimple1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvingoujAtDevolution @keepsimple1