Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support special meta-query of dns-sd #14

Merged
merged 16 commits into from
Feb 6, 2022
Merged

support special meta-query of dns-sd #14

merged 16 commits into from
Feb 6, 2022

Conversation

keepsimple1
Copy link
Owner

This is to issue #13 when a wildcard browsing _services._dns-sd._udp.local. did not work.

This is a missing feature. The spec is here: https://datatracker.ietf.org/doc/html/rfc6763#section-9.

Test and example code are added.

@keepsimple1
Copy link
Owner Author

keepsimple1 commented Feb 5, 2022

It is strange that the new test only fails in GitHub and succeeds in local macOS and Linux.

UPDATE: it is due to incorrect parameters in ServiceInfo. After fixing the code, the test passed.

@keepsimple1 keepsimple1 added the enhancement New feature or request label Feb 5, 2022
@keepsimple1 keepsimple1 removed the enhancement New feature or request label Feb 5, 2022
@keepsimple1 keepsimple1 added the enhancement New feature or request label Feb 6, 2022
@keepsimple1 keepsimple1 merged commit 146d42a into main Feb 6, 2022
@keepsimple1 keepsimple1 deleted the wildcard branch February 6, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant