impl AsIpv4Addrs for reference types (#23)

keepsimple1 · May 17, 2022 · 7c53e87 · 7c53e87
1 parent 411e9bc
commit 7c53e87
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -1395,6 +1395,12 @@ pub trait AsIpv4Addrs {
     fn as_ipv4_addrs(&self) -> Result<HashSet<Ipv4Addr>>;
 }
 
+impl<T: AsIpv4Addrs> AsIpv4Addrs for &T {
+    fn as_ipv4_addrs(&self) -> Result<HashSet<Ipv4Addr>> {
+        (*self).as_ipv4_addrs()
+    }
+}
+
 impl AsIpv4Addrs for &str {
     fn as_ipv4_addrs(&self) -> Result<HashSet<Ipv4Addr>> {
         let mut addrs = HashSet::new();

diff --git a/tests/addr_parse.rs b/tests/addr_parse.rs
@@ -1,8 +1,6 @@
-use std::collections::HashSet;
-use std::iter::FromIterator;
-
 use mdns_sd::AsIpv4Addrs;
 use nix::sys::socket::Ipv4Addr;
+use std::collections::HashSet;
 
 #[test]
 fn test_addr_str() {
@@ -27,6 +25,17 @@ fn test_addr_str() {
         })
     );
 
+    // verify that `&String` also works.
+    assert_eq!(
+        (&addr).as_ipv4_addrs(),
+        Ok({
+            let mut set = HashSet::new();
+            set.insert(Ipv4Addr::from_std(&std::net::Ipv4Addr::new(127, 0, 0, 1)));
+
+            set
+        })
+    );
+
     assert_eq!(
         "127.0.0.1,127.0.0.2".as_ipv4_addrs(),
         Ok({