builtins debugging #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
commented
Mar 22, 2024
Comment on lines
+143
to
+147
| let val = if (val == MaybeRelocatable::RelocatableValue(Relocatable{segment_index: -3, offset: 0})) { | ||
| MaybeRelocatable::RelocatableValue(Relocatable{segment_index: -3, offset: 1}) | ||
| } else { | ||
| val | ||
| }; |
There was a problem hiding this comment.
This ugly hack works around the DiffAssertValues issue by modifying a specific pointer when we encounter it.
Remove this in order to reproduce the issue; with it in place we are able to progress further through the OS code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dump of debugging code while trying to debug an issue with selected builtins.
I think the culprit is
update_builtin_ptrs(or some previous logic it depends on) because it looks like it should be finding 2 selected builtins but finds 0, and this leads to aDiffAssertValueassertion failure later on.