Fix: Get classes out of subcalls #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
force-pushed
the
notlesh/get-classes-from-library-subcalls
branch
from
8d0bb4c to
a95d365
Compare
notlesh
changed the title
odesenfans
approved these changes
Sep 4, 2024
notlesh
added a commit
that referenced
this pull request
Sep 5, 2024
HermanObst
pushed a commit
that referenced
this pull request
Sep 10, 2024
* wip: attempt to handle kzq_da * add: wip kzg da hints implementation * wip: kzg unknown da_size * lint: clippy fix * fix: rename zkg to kzg * update: kzg fft method and tests * ensure non-negative numbers on diff * fix: os output and add specific tests * lint: clippy fixes * fix: update the new api * more zkg -> kzg renaming * fix: use log instead of println Co-authored-by: Olivier Desenfans <[email protected]> * fix: remove unnecessary code * Update crates/starknet-os/src/hints/kzg.rs Co-authored-by: Olivier Desenfans <[email protected]> * fix: missing parts of kzg, added vars * L1 handler tx (#344) * support for L1 Handler txs * fixes from review * Chore: bump Blockifier to 0.8.0-rc.3 (#345) * Look for classes in subcalls in addition to contracts (#347) * Implement kzg commitment hint * Fixes * Clean up post-merge * Add kzg_manager.rs * Resolve clippy nits * s/5/6/ * Remove orphaned hint * Clean up mangled comment * Remove unused import * Fix BLOB_LENGTH constant lookup * Use from c_kzg::Error Co-authored-by: Olivier Desenfans <[email protected]> * Add Blob DA blocks to prove_block test * Oops, wrong block number * Derive number of zkg felts to ignore in os output * doc: improve documentation on fft recursive method * doc: for the recursive fft method --------- Co-authored-by: ftheirs <[email protected]> Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Stephen Shelton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Library calls do not have a distinct contract address (they use the caller's address in their context), so looking only at contract addresses in subcalls prevents us from ever loading these classes.
Solution: Record classes while traversing subcall tree and load them.
Issue Number: N/A
Type
Description
Breaking changes?