clean up Invoke tx #343
Merged
clean up Invoke tx #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftheirs
force-pushed
the
ft/invoke_tx_improvements
branch
from
0618d7a to
5c4be59
Compare
odesenfans
approved these changes
Sep 3, 2024
| @@ -37,63 +40,60 @@ fn da_mode_core_to_api( | |||
| } | |||
| } | |||
|
|
|||
| fn felt_to_fee(fee: Felt) -> Result<Fee, StarknetApiError> { | |||
| let fee_u128 = fee | |||
There was a problem hiding this comment.
We have a felt_to_u128 utility already, can you use that one instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem PR #330 was too big
Solution: split the PR into smaller PR where each one will implement a different transaction.
Clean up and modularize Invoke tx
Issue Number: N/A
Type
Description
Breaking changes?