Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement SECP related missing hints #299

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

whichqua
Copy link
Collaborator

@whichqua whichqua commented Aug 6, 2024

This PR adds hints and compatibility with secp syscalls.

Issue Number: N/A
Requires: Moonsong-Labs/cairo-vm#41

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@whichqua whichqua marked this pull request as ready for review August 7, 2024 14:19
@whichqua whichqua requested a review from notlesh as a code owner August 7, 2024 14:19
@whichqua whichqua requested a review from odesenfans August 8, 2024 07:32
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM!

@odesenfans odesenfans merged commit 7da067c into dev-secp-support Aug 29, 2024
6 checks passed
@odesenfans odesenfans deleted the gm/secp-hints branch August 29, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants