Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust messaging messages status + add testing feature #44

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Jan 9, 2025

This PR had two objectives:

  1. Fixing some computation around messaging that were wrong. Also, the status of the messages to app chain is now clearer and directly stored in the storage instead of relying on a magic value.
  2. Adding to piltover a functionality to be tested without relying on the proof. By adding a function to register the messages hashes, this ease the local testing, exampled for Katana here.

The new functionality to test the messaging is gated under the messaging_test feature. Which should be ignored for code being built in production.

@glihm glihm requested a review from b-j-roberts as a code owner January 9, 2025 06:49
@glihm
Copy link
Collaborator Author

glihm commented Jan 9, 2025

About the bindings, may be better to have a /bin that we can call to generate the bindings + check if they are up to date.

Then having a /lib to be imported by other projects without them having to rebuild it.

WDYT?

@glihm glihm merged commit a5a9a79 into main Jan 28, 2025
3 checks passed
@glihm glihm deleted the feat/messaging-test branch January 28, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant