Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates files upgrading nargo/bb to 1.0.0-beta.1/0.66.0 #291

Merged
merged 38 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
bf530de
Adds the isolated test for honk calldata
raugfer Jan 16, 2025
676b2bd
Adds honk calldata builder as an isolated python file for guidance
raugfer Jan 17, 2025
021079a
More adjustments to test_honk_calldata.py to simplify translation
raugfer Jan 17, 2025
5325a4c
Fixes HonkProof field types
raugfer Jan 17, 2025
26ce940
Saving temporary work on honk_calldata.rs
raugfer Jan 18, 2025
31f837d
Wraps up preliminary implementation of honk calldata and starts addin…
raugfer Jan 20, 2025
6c03a23
Adds missing data to test cases
raugfer Jan 21, 2025
969f360
Fixes transcript generation from proof
raugfer Jan 21, 2025
619f92a
Fixes circuit_compute_shplemini_msm_scalars for Rust
raugfer Jan 21, 2025
fbde949
Adds parsing of honk vk/proof from byte array
raugfer Jan 21, 2025
ef21805
Adds preliminary python/wasm bidings and adopts groth16-like organiza…
raugfer Jan 23, 2025
b386177
Fixes wasm bindings for honk calldata
raugfer Jan 23, 2025
f3bb015
Adds pytest for honk calldata generation
raugfer Jan 23, 2025
23dec2e
Adds honk calldata generation interfaces/function to TypeScript
raugfer Jan 23, 2025
54c8715
Adds Honk proof/vk parser in TypeScript
raugfer Jan 23, 2025
d7c9fb5
Fixes parsing buffer range condition
raugfer Jan 23, 2025
bc24988
Fixes WASM binding for get_honk_calldata
raugfer Jan 24, 2025
a6885d1
Merge branch 'main' into honk-calldata-rust
raugfer Jan 24, 2025
3975ad2
Adds system parameter to honk vk/proof parsing/calldata test
raugfer Jan 24, 2025
70cb4b4
Fixes formatting for hydra/garaga/starknet/honk_contract_generator/ca…
raugfer Jan 24, 2025
55b4edf
Fixes import from test_honk_vk_proof_parsing.py
raugfer Jan 24, 2025
3d82a21
Adds alternate code for calldata generation, not yet tested
raugfer Jan 28, 2025
aae212e
Finishes adjusting the data types for proof/vk/transcript
raugfer Jan 28, 2025
f6115dc
Updates WASM gnerated from Rust
raugfer Jan 28, 2025
6e0a60e
Wraps up refactor of honk.rs
raugfer Jan 29, 2025
b0f61c7
Updates WASM module generated from Rust
raugfer Jan 29, 2025
004ee62
Removes temporary test file for the honk calldata
raugfer Jan 29, 2025
b6b6b39
Adds WASM bindings to parse honk proof/vk from binary format
raugfer Jan 29, 2025
6a559f3
Updates WASM module generated from Rust
raugfer Jan 29, 2025
3b318a0
Replaces Honk proof/vk parsing from pure TypeScript to WASM generated…
raugfer Jan 29, 2025
3ca8091
Replaces unit tests data by Keccak hash
raugfer Jan 30, 2025
4fb91b1
Updates scripts and ultra keccak vk/proof to handle bb 0.66.0/nargo 1…
raugfer Jan 30, 2025
8a68f43
Adds ultra starknet proof generated with bb 0.66.0 and updates rust u…
raugfer Jan 30, 2025
0038cc7
Runs make rewrite to update honk_verifier_constants.cairo
raugfer Jan 30, 2025
d099051
Merge branch 'main' into nargo-bb-upgrade
raugfer Feb 7, 2025
a2996ff
Updates honk calldata tests keccak output contants
raugfer Feb 7, 2025
55dac38
Updates WASM module generated from Rust
raugfer Feb 7, 2025
400f72e
Remove compiler version.
feltroidprime Feb 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,15 @@ pub const vk: HonkVk = HonkVk {
},
lagrange_last: G1Point {
x: u384 {
limb0: 0x71fba7a412dd61fcf34e8ceb,
limb1: 0x71155617b6af56ee40d90bea,
limb2: 0x140b0936c323fd24,
limb0: 0x868487222aa54f3268ab64a2,
limb1: 0x7c94249535bba7fcbd3f412f,
limb2: 0x1b8afad764d2cbe6,
limb3: 0x0,
},
y: u384 {
limb0: 0x185c5ff8e440fd3d73b6fefc,
limb1: 0xc87d652e059df42b90071823,
limb2: 0x2b6c10790a5f6631,
limb0: 0xe415445bd0c84309caaf213e,
limb1: 0x5096aad8a0cc5d4c1d1cdb0f,
limb2: 0x1b70a90a334c9bd,
limb3: 0x0,
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,15 @@ pub const vk: HonkVk = HonkVk {
},
lagrange_last: G1Point {
x: u384 {
limb0: 0x71fba7a412dd61fcf34e8ceb,
limb1: 0x71155617b6af56ee40d90bea,
limb2: 0x140b0936c323fd24,
limb0: 0x868487222aa54f3268ab64a2,
limb1: 0x7c94249535bba7fcbd3f412f,
limb2: 0x1b8afad764d2cbe6,
limb3: 0x0,
},
y: u384 {
limb0: 0x185c5ff8e440fd3d73b6fefc,
limb1: 0xc87d652e059df42b90071823,
limb2: 0x2b6c10790a5f6631,
limb0: 0xe415445bd0c84309caaf213e,
limb1: 0x5096aad8a0cc5d4c1d1cdb0f,
limb2: 0x1b70a90a334c9bd,
limb3: 0x0,
},
},
Expand Down
8 changes: 4 additions & 4 deletions tools/garaga_rs/src/calldata/full_proof_with_hints/honk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1051,8 +1051,8 @@ mod tests {
.collect::<Vec<_>>();
let digest = Keccak256::digest(&bytes).to_vec();
let expected_digest = [
224, 10, 52, 69, 230, 56, 254, 216, 57, 22, 36, 162, 198, 40, 56, 222, 3, 82, 253, 49,
43, 53, 159, 120, 148, 181, 90, 213, 85, 236, 98, 79,
103, 55, 221, 223, 7, 64, 139, 128, 242, 97, 151, 105, 184, 84, 236, 64, 137, 211, 211,
235, 145, 116, 32, 146, 222, 141, 34, 170, 125, 140, 72, 121,
];
assert_eq!(digest, expected_digest);
Ok(())
Expand All @@ -1069,8 +1069,8 @@ mod tests {
.collect::<Vec<_>>();
let digest = Keccak256::digest(&bytes).to_vec();
let expected_digest = [
138, 80, 251, 246, 114, 144, 30, 131, 162, 59, 6, 234, 99, 117, 135, 213, 61, 10, 129,
116, 19, 82, 226, 142, 180, 170, 113, 118, 181, 140, 24, 236,
89, 155, 64, 84, 230, 213, 95, 238, 214, 157, 58, 50, 7, 154, 218, 195, 165, 140, 145,
19, 74, 191, 197, 254, 233, 208, 172, 209, 131, 237, 230, 182,
];
assert_eq!(digest, expected_digest);
Ok(())
Expand Down
1 change: 0 additions & 1 deletion tools/noir/hello/Nargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
name = "hello"
type = "bin"
authors = [""]
compiler_version = ">=0.36.0"

[dependencies]
4 changes: 2 additions & 2 deletions tools/noir/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ reset
BB_PATH="bb"


echo "nargo version : $(nargo --version)" # 0.36.0
echo "bb version : $($BB_PATH --version)" # 0.61.0
echo "nargo version : $(nargo --version)" # 1.0.0-beta.1
echo "bb version : $($BB_PATH --version)" # 0.66.0


run_noir_proof_basic() {
Expand Down
Loading