Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

test mint verification #34

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

NehharShah
Copy link
Contributor

@NehharShah NehharShah commented Oct 22, 2024

Pull Request: Fix Mint Verification and Address Warnings

Test Results

  • Total tests: 12
  • Passing: 7
  • Failing: 5

Details

The changes include:

  1. Addressing undefined or private function warnings in MintController
  2. Fixing unused variable warnings in LightningLib and Nut03.Impl
  3. Resolving the undefined Benchee.run/2 warning
  4. Correcting issues in the Mint Verification tests

Failed Tests

The following tests are currently failing:

  1. InputsAndOutputs.verify!/3 raises error for invalid amount and fee
  2. Inputs.verify!/2 raises error for duplicate secrets
  3. Inputs.verify!/2 passes for valid inputs
  4. Outputs.verify!/2 passes for valid outputs
  5. Outputs.verify!/2 raises error for different keyset ids

Next Steps

  • Investigate and resolve the failing tests, particularly focusing on:
    • Ensuring proper error handling in InputsAndOutputs.verify!/3
    • Correcting the error message for duplicate secrets in Inputs.verify!/2
    • Fixing the "BlindMessageAmountNotExceed2^MaxOrder" error in Inputs.verify!/2
    • Addressing the ArgumentError in Outputs.verify!/2
  • Review and update the implementation of Mint.Verification.Amount.verify!/1
  • Double-check the usage of MapSet in the verification process

Reviewers

@tdelabro

  • Please review the changes.

@tdelabro tdelabro merged commit 837f821 into keep-starknet-strange:main Oct 24, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants