This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Update Go contract bindings: resubscription mechanism and subscription background monitoring loop #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated keep-common dependency to the version refactoring event subscriptions by adding background monitoring loop in case event was lost.
Go contract bindings regenerated after updating keep-common dependency. The regenerated bindings contains additional background monitoring loop for all event subscriptions in case an event was lost for whatever reason.
Updated keep-common dependency to the most recent one on master branch after merging the feature branch with Go contract bindings refactoring.
Regenerated contract bindings after updating keep-common dependency to the most recent version.
nkuba
approved these changes
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs keep-network/keep-ecdsa#680
Depends on keep-network/keep-common#62
Depends on keep-network/keep-common#63
The referenced PRs from
keep-commonrepository refactor Go contract bindings updating Ethereum event resubscription mechanism and adding subscription background monitoring loop in case an event was lost for whatever reason. The full reasoning behind those changes is explained in the referenced PRs.Here we update
keep-commondependency and regenerate contract bindings to include the mentioned changes.Leaving as a Draft until the two referenced PRs are not merged.
Please do not merge this PR until
keep-commondependency is updated to the merge commit fromkeep-common.