Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telemetry docs for opt-out model #4040

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Jul 29, 2024

Description

Update the telemetry section of the Kedro documentation following the transition to an opt-out model for telemetry.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

DimedS added 2 commits July 29, 2024 16:11
Signed-off-by: Dmitry Sorokin <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
@DimedS DimedS marked this pull request as ready for review July 29, 2024 15:23
@DimedS DimedS requested a review from yetudada as a code owner July 29, 2024 15:23
@DimedS DimedS requested review from lrcouto and ElenaKhaustova July 30, 2024 11:38
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thank you @DimedS 🙏🏼

Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DimedS!

I approve the PR but we can wait until kedro-org/kedro-plugins#785 is resolved before merging it, so we make sure that our docs align with the solution.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with just one outstanding comment #4040 (comment) depending on the resolution of the corresponding issue

@DimedS
Copy link
Member Author

DimedS commented Aug 1, 2024

Approved, with just one outstanding comment #4040 (comment) depending on the resolution of the corresponding issue

Thank you! The bug fix is approved, so I believe no warning is needed.

@DimedS DimedS merged commit c0d2bac into main Aug 1, 2024
10 checks passed
@DimedS DimedS deleted the 731-kedro-update-telemetry-docs-for-opt-out-model branch August 1, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro-telemetry: update telemetry docs for opt-out model
4 participants