Add implementation of telemetry consent flag for kedro run #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
…g/kedro into add-telemetry-flag-to-kedro-run
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
4 tasks
merelcht
reviewed
May 20, 2024
kedro/framework/cli/utils.py
Outdated
| @@ -497,3 +497,38 @@ def _split_load_versions(ctx: click.Context, param: Any, value: str) -> dict[str | |||
| load_versions_dict[load_version_list[0]] = load_version_list[1] | |||
|
|
|||
| return load_versions_dict | |||
|
|
|||
|
|
|||
| def validate_input_with_regex_pattern(pattern_name: str, input: str) -> None: | |||
There was a problem hiding this comment.
I think this should still be a private method as we don't want users to start using this.
kedro/framework/cli/utils.py
Outdated
| sys.exit(1) | ||
|
|
||
|
|
||
| def parse_yes_no_to_bool(value: str) -> Any: |
There was a problem hiding this comment.
Same here. And I'm actually thinking that the name is a bit misleading. If I understand correctly this parses yes to True, but otherwise returns None, so maybe it should be named parse_yes_to_bool ?
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: L. R. Couto <[email protected]>
astrojuanlu
pushed a commit
that referenced
this pull request
May 24, 2024
bpmeek
pushed a commit
to bpmeek/kedro
that referenced
this pull request
Jun 20, 2024
…edro-org#3876)" (kedro-org#3888) This reverts commit 570f66a. Signed-off-by: bpmeek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
--telemetryflag tokedro run, similar to the one inkedro new. Allows consent to telemetry to be granted or revoked at the same time as theruncommand is called.Works together with kedro-org/kedro-plugins#681, that is required so the user will not receive the prompt to grant consent if it's given through the CLI flag.
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile