-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Docs mega nav #3168
[DRAFT] Docs mega nav #3168
Conversation
No comment other than rad PR title |
This is great, thanks @vladimir-mck! Built docs are here for people wanting a preview: https://kedro--3168.org.readthedocs.build/en/3168/# I'm not sure how much review you want at this as it's in draft, but I've added @stephkaiser and @tynandebold here for visibility and their thoughts. From my side, some basic comments:
|
Marking this as a draft, feel free to mark it as ready for review whenever you want @vladimir-mck 👍🏽 The style changes are looking good so far! |
@vladimir-mck I've changed the base branch to |
Closing this PR, it will be handled with this one |
Description
This PR was created as a first step to creating a global navigation for docs as per #3024
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file