Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mehdi to the TSC #3046

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Add Mehdi to the TSC #3046

merged 5 commits into from
Sep 20, 2023

Conversation

stichbury
Copy link
Contributor

@stichbury stichbury commented Sep 19, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

In response to #3039 plus I'm adding @MehdiNV to the TSC list

Development notes

Revised the list of names to group into QB plus other affiliation (if I add QB labs to everyone it looks messy, so I've gone for this approach). Added @MehdiNV so DO NOT MERGE THIS until I have 12 👍 votes please.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@stichbury
Revise TSC page + add Mehdi
8d8e21d 
Signed-off-by: Jo Stichbury <[email protected]>
@stichbury stichbury added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Sep 19, 2023
@stichbury stichbury requested a review from yetudada as a code owner September 19, 2023 08:56
@stichbury stichbury self-assigned this Sep 19, 2023
@stichbury stichbury changed the title Revise TSC page + add Mehdi [VOTING - do NOT merge] Revise TSC page + add Mehdi Sep 19, 2023
@stichbury stichbury mentioned this pull request Sep 19, 2023
Closed
@stichbury stichbury changed the title [VOTING - do NOT merge] Revise TSC page + add Mehdi [VOTING - do NOT merge] Add Mehdi to the TSC Sep 20, 2023
@stichbury stichbury changed the title [VOTING - do NOT merge] Add Mehdi to the TSC Add Mehdi to the TSC Sep 20, 2023
@stichbury stichbury enabled auto-merge (squash) September 20, 2023 08:59
astrojuanlu
astrojuanlu approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Welcome @MehdiNV!

@stichbury stichbury merged commit 6d11f00 into main Sep 20, 2023
@stichbury stichbury deleted the revise-tsc branch September 20, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepyaman deepyaman deepyaman left review comments

@yetudada yetudada yetudada left review comments

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@tynandebold tynandebold tynandebold approved these changes

@marrrcin marrrcin Awaiting requested review from marrrcin

@merelcht merelcht Awaiting requested review from merelcht

Assignees

@stichbury stichbury

Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stichbury @astrojuanlu @deepyaman @tynandebold @yetudada