Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DELETE #2655

Closed
wants to merge 1 commit into from
Closed

DELETE #2655

wants to merge 1 commit into from

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jun 7, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

ab1f7c8 was merged incorrectly as a Squash Merge instead of Merge Commit, this may create issues when we need to sync develop to main so it's better to stay on the safe side.

#2654

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@noklam noklam changed the base branch from main to develop June 7, 2023 15:55
@noklam noklam changed the title Revert squash commit DELETE Jun 7, 2023
@noklam noklam closed this Jun 7, 2023
@merelcht merelcht deleted the revert-squash-commit branch September 28, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yetudada yetudada Awaiting requested review from yetudada yetudada will be requested when the pull request is marked ready for review yetudada is a code owner

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu will be requested when the pull request is marked ready for review astrojuanlu is a code owner

@merelcht merelcht Awaiting requested review from merelcht merelcht will be requested when the pull request is marked ready for review merelcht is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@noklam