Refactor modular pipeline expansions to instantly update UI

[SajidAlamQB]

Description

This PR updates the logic for determining which nodes are visible when toggling expandAllPipelines. Previously, modular pipeline expansions were applied once during initial start, requiring data reloads to see changes. Now, the visibility logic is integrated directly into disabled.js, allowing the UI to reflect state changes immediately.

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added new entries to the RELEASE.md file
• Added tests to cover my changes

[rashidakanchwala]

The expand/collapse doesn't work with the NodeList in the sidebar.

[SajidAlamQB]

I noticed for the first time the toggle doesn't update the view instantly but subsequent presses do.

[rashidakanchwala]

I noticed for the first time the toggle doesn't update the view instantly but subsequent presses do.

yeah i noticed that too.

[SajidAlamQB]

I noticed for the first time the toggle doesn't update the view instantly but subsequent presses do.

Fixed the onToggleExpandPipelines was toggling wrong way around.

[rashidakanchwala]

I have left some minor comments. Around repeated code

[Huongg]

Hey @SajidAlamQB, thank you for the updates! I have two main comments:

• Could we rename the reducers TOGGLE_EXPAND_ALL_PIPELINES and TOGGLE_ALL_MODULAR_PIPELINES_EXPANDED to better reflect their purpose?

• Both TOGGLE_ALL_MODULAR_PIPELINES_EXPANDED and normalize share similar logic (I replicated the logic from normalize). Could this be moved to a helper function?

[rashidakanchwala]

Hi Sajid, left two minor comments. Once those are fixed, then it should be good to merge. I am approving it for now.

[ravi-kumar-pilla]

Hi @SajidAlamQB , Thank you for the PR. The code looks fine but I do not have complete context on the issue and I am finding it difficult understanding the variable names and what they do. I left few comments to clarify and better QA this PR. Thank you

[rashidakanchwala]

Hi @SajidAlamQB , Thank you for the PR. The code looks fine but I do not have complete context on the issue and I am finding it difficult understanding the variable names and what they do. I left few comments to clarify and better QA this PR. Thank you

@ravi-kumar-pilla , this PR is just a refactor, earlier 'Expand All Pipelines' did a page reload everytime it was clicked, now it just uses redux actions as page reload was a bit of an overkill.

[ravi-kumar-pilla]

@ravi-kumar-pilla , this PR is just a refactor, earlier 'Expand All Pipelines' did a page reload everytime it was clicked, now it just uses redux actions as page reload was a bit of an overkill.

For some reason, I do not see a page reload on Expand All Pipelines click. I do see a main api call but not an entire page reload. I think we have an entire page reload only for changes in the Settings panel.

[rashidakanchwala]

Apologies, not page load, that was incorrect term. The 'expand pipelines' functionality would trigger the URL parameter, which in turn ran preparePipelineState and then the pipelines got expanded. However, this didn't work with VSCode; right Sajid? Now, this happens directly through a redux trigger

[ravi-kumar-pilla]

LGTM 👍 ... Thank you @SajidAlamQB . I am not sure if we want to track this change in the release note.

[SajidAlamQB]

Apologies, not page load, that was incorrect term. The 'expand pipelines' functionality would trigger the URL parameter, which in turn ran preparePipelineState and then the pipelines got expanded. However, this didn't work with VSCode; right Sajid? Now, this happens directly through a redux trigger

Yes that's correct although even this refactor still hasn't fixed the issue on vscode extension which probably has a more underlying issue on the extension side.