Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor aws_kinesis_stream_scaler #6400

Merged
merged 2 commits into from
Dec 7, 2024
Merged

refactor aws_kinesis_stream_scaler #6400

merged 2 commits into from
Dec 7, 2024

Conversation

omerap12
Copy link
Contributor

@omerap12 omerap12 commented Dec 2, 2024

Refactor aws kinesis stream scaler configuration

Checklist

Fixes #5797

Relates to #

@omerap12 omerap12 requested a review from a team as a code owner December 2, 2024 18:57
@wozniakjan
Copy link
Member

wozniakjan commented Dec 2, 2024 •
edited by github-actions bot
Loading

/run-e2e aws_kinesis
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan enabled auto-merge (squash) December 2, 2024 19:19
auto-merge was automatically disabled December 7, 2024 12:54

Head branch was pushed to by a user without write access

@omerap12
Copy link
Contributor Author

omerap12 commented Dec 7, 2024

@wozniakjan Can you please re-approve? I had to rebase :)

@zroubalik
Copy link
Member

zroubalik commented Dec 7, 2024 •
edited by github-actions bot
Loading

/run-e2e aws_kinesis
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) December 7, 2024 13:20
@zroubalik zroubalik merged commit 88ddc39 into kedacore:main Dec 7, 2024
19 checks passed
ctccxxd pushed a commit to ctccxxd/keda that referenced this pull request Dec 10, 2024
@omerap12 @ctccxxd
refactor aws_kinesis_stream_scaler (kedacore#6400)
9bd754b 
Signed-off-by: Omer Aplatony <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
@omerap12 @chiragbhatia8
refactor aws_kinesis_stream_scaler (kedacore#6400)
fbe4e0c 
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Scalers with new declarative scaler config
3 participants
@omerap12 @wozniakjan @zroubalik