Removal of Microsoft ADAL identity and to use azidentity(MSAL) #6280 #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| if _, ok := authConfig.(ADWorkloadIdentityConfig); !ok { | ||
| t.Errorf("Test: %v; incorrect auth config. expected ad workload identity config", testData.testName) | ||
| } | ||
| authToken, err := GetAzureADWorkloadIdentityToken(context.TODO(), testData.info.ClientID, testData.info.TenantID, "", testData.info.AppInsightsResourceURL) |
There was a problem hiding this comment.
Consider to use well-defined context
🎉 Fixed in commit 23603d7 🎉
aagusuab
force-pushed
the
adal_remove
branch
6 times, most recently
from
11f7818 to
23603d7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aagusuab
force-pushed
the
adal_remove
branch
from
23603d7 to
5832393
Compare
|
/run-e2e |
Deprecating ADAL Signed-off-by: Youn Jae Kim <[email protected]>
Signed-off-by: Youn Jae Kim <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #
Relates to #