-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulsar: remove deprecated trigger name #6092
Conversation
5f4a7a1
to
d095a3c
Compare
Could you sign the branch please?
|
@JorTurFer Done! |
Signed-off-by: Kun Woo Yoo <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Kun Woo Yoo <[email protected]>
Signed-off-by: Kun Woo Yoo <[email protected]>
@JorTurFer Done! (for real this time) |
/run-e2e pulsar |
* remove deprecated trigger name in Pulsar scaler Signed-off-by: Kun Woo Yoo <[email protected]> * Update CHANGELOG.md Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Kun Woo Yoo <[email protected]> * remove deprecated Pulsar trigger name from test Signed-off-by: Kun Woo Yoo <[email protected]> --------- Signed-off-by: Kun Woo Yoo <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
* remove deprecated trigger name in Pulsar scaler Signed-off-by: Kun Woo Yoo <[email protected]> * Update CHANGELOG.md Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Kun Woo Yoo <[email protected]> * remove deprecated Pulsar trigger name from test Signed-off-by: Kun Woo Yoo <[email protected]> --------- Signed-off-by: Kun Woo Yoo <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: michael pechner <[email protected]>
* remove deprecated trigger name in Pulsar scaler Signed-off-by: Kun Woo Yoo <[email protected]> * Update CHANGELOG.md Signed-off-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Kun Woo Yoo <[email protected]> * remove deprecated Pulsar trigger name from test Signed-off-by: Kun Woo Yoo <[email protected]> --------- Signed-off-by: Kun Woo Yoo <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Chirag Bhatia <[email protected]>
This commit removes the deprecated trigger name
msgBacklog
in Pulsar scaler.msgBacklogThreshold
should be used instead.Checklist
Fixes #6059
(The original issue was intended to introduce a scaler to non-persistent Pulsar topics. But after some research, I found out that the proposed metric is infeasible)
Relates to #